From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 529674696C3 for ; Thu, 16 Apr 2020 03:46:07 +0300 (MSK) Date: Thu, 16 Apr 2020 03:46:01 +0300 From: Alexander Turenko Message-ID: <20200416004601.yll6nd6k5iiiqgcb@tkn_work_nb> References: <444a8a7266df491e922ab2a670852a16d6586569.1586957521.git.avtikhon@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <444a8a7266df491e922ab2a670852a16d6586569.1586957521.git.avtikhon@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2] gitlab-ci: remove Ubuntu 19.04 Disco List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: Oleg Piskunov , tarantool-patches@dev.tarantool.org LGTM. On Wed, Apr 15, 2020 at 04:32:39PM +0300, Alexander V. Tikhonov wrote: > [PATCH v2] gitlab-ci: remove Ubuntu 19.04 Disco Nit: Strictly speaking, it is not solely re GitLab CI, but also removes the job from Travis-CI. As I see, we use 'travis-ci/gitlab-ci' prefix before two times: $ git log --oneline | grep travis-ci/gitlab-ci: 961e8c5fe travis-ci/gitlab-ci: remove Ubuntu 18.10 Cosmic c6cd2e627 travis-ci/gitlab-ci: add ubuntu 19.10 > > Removed Ubuntu 19.04 Disco from testing which is EOL. Nit: ...Disco, which is EOL, from testing -- this is better :) > > Close #4896 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci > Issue: https://github.com/tarantool/tarantool/issues/4896