From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7AB914696C3
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 16 Apr 2020 03:03:37 +0300 (MSK)
Date: Thu, 16 Apr 2020 00:03:36 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200416000336.GA2581@tarantool.org>
References: <cover.1585308644.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1585308644.git.imeevma@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v4 0/3] sql: fix CAST() from BLOB to
	INTEGER
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

On 27 Mar 14:33, imeevma@tarantool.org wrote:
> This patch-set fixes CAST() from BLOB to INTEGER in case a BLOB
> does not have '\0'.
> 
> https://github.com/tarantool/tarantool/issues/4766
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4766-fix-blob-size-for-cast
> 
> @Changelog
>  - Explicit and implicit cast from string contains DOUBLE value to
>    INTEGER or UNSIGNED was disallowed.
>  - Maximum length of a BLOB that is allowed to be cast to INTEGER
>    or UNSIGNED was limited to 12287 bytes.
>  - Fixed wrong behaviour of CAST() from BLOB to INTEGER in case a
>    BLOB does not have '\0'. (gh-4766)

Pushed to master, updated changelog, dropped branch.
 
> Mergen Imeev (3):
>   sql: fix CAST() from STRING to INTEGER
>   sql: fix implicit cast from STRING to INTEGER
>   sql: add '\0' to the BLOB when it is cast to INTEGER
> 
>  src/box/sql/util.c                                 |  17 ++-
>  src/box/sql/vdbe.c                                 |  11 +-
>  src/box/sql/vdbeInt.h                              |   1 -
>  src/box/sql/vdbemem.c                              |  45 ++-----
>  test/sql-tap/e_select1.test.lua                    |   2 +-
>  .../gh-4766-wrong-cast-from-blob-to-int.test.lua   | 150 +++++++++++++++++++++
>  test/sql-tap/intpkey.test.lua                      |   2 +-
>  test/sql-tap/join.test.lua                         |   4 +-
>  test/sql-tap/subquery.test.lua                     |   6 +-
>  test/sql-tap/tkt-9a8b09f8e6.test.lua               |   4 +-
>  test/sql/types.result                              |  23 ++--
>  11 files changed, 203 insertions(+), 62 deletions(-)
>  create mode 100755 test/sql-tap/gh-4766-wrong-cast-from-blob-to-int.test.lua
> 
> -- 
> 2.7.4
>