From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 25A2F4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 16 Apr 2020 02:57:19 +0300 (MSK)
Date: Thu, 16 Apr 2020 02:57:13 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200415235713.3cnw2zdrqwhru5mx@tkn_work_nb>
References: <cover.1586862436.git.alexander.turenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1586862436.git.alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 00/12] Popen Lua API: preliminary
	patches 2
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org

On Tue, Apr 14, 2020 at 02:38:09PM +0300, Alexander Turenko wrote:
> It is the second patchset of preparation patches that are needed to
> implement Lua API for popen.
> 
> See the previous series here (already pushed to master):
> https://lists.tarantool.org/pipermail/tarantool-patches/2020-April/015609.html
> 
> https://github.com/tarantool/tarantool/issues/4031
> https://github.com/tarantool/tarantool/tree/Totktonada/gh-4031-popen-lua-api-preparation-2
> 
> I also pushed the same commit to *-full-ci branch to verify it on all
> platforms:
> 
> https://github.com/tarantool/tarantool/tree/Totktonada/gh-4031-popen-lua-api-preparation-2-full-ci

CCed Kirill.

Added two patches upward (now the patchset contains 14 patches). Got
ACKs for all patches from Cyrill. Updated the both branches (see above).
GitLab CI looks okay (Travis CI jobs are pending).

Kirill, the patchset seems to be ready to final review and push.

> Alexander Turenko (10):
>   popen: log a reason of close inherited fds failure
>   popen: add missed diag_set() in popen_new()
>   popen: remove retval from popen_stat()
>   popen: quote multiword command arguments
>   popen: add logging of duplicated logger fd
>   popen: fix close-on-exec flag setting
>   popen: clarify popen_{signal,delete} contract
>   popen: add FIXME re group signal flaw
>   popen: clarify popen_read_timeout error message
>   popen: allow to close parent's end of std* fds

Added:

Alexander Turenko (2):
  popen: fix popen_write_timeout retval type
  popen: add caution comment for popen_may_io()

> 
> Cyrill Gorcunov (2):
>   popen: allow to kill process group
>   popen: add ability to keep child on deletion