From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3854F4696C4
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 16 Apr 2020 00:45:47 +0300 (MSK)
Date: Thu, 16 Apr 2020 00:45:42 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200415214542.f2nnkqadsk3mdans@tkn_work_nb>
References: <cover.1586862436.git.alexander.turenko@tarantool.org>
 <6873a6070a181c7c47f2e94295539c483fd6e7b7.1586862436.git.alexander.turenko@tarantool.org>
 <20200414130507.GH3072@uranus>
 <20200415042112.ur5anngvrhn7mmrl@tkn_work_nb>
 <20200415074327.GL3072@uranus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200415074327.GL3072@uranus>
Subject: Re: [Tarantool-patches] [PATCH 12/12] popen: allow to close
	parent's end of std* fds
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org

On Wed, Apr 15, 2020 at 10:43:27AM +0300, Cyrill Gorcunov wrote:
> On Wed, Apr 15, 2020 at 07:21:12AM +0300, Alexander Turenko wrote:
> > 
> > The diff at bottom of the email.
> 
> Ack

Changed after last wording fixes in 'refine popen_{read,write}_timeout
errors' (incremental diff):

diff --git a/src/lib/core/popen.c b/src/lib/core/popen.c
index 638826fb9..3a12a439b 100644
--- a/src/lib/core/popen.c
+++ b/src/lib/core/popen.c
@@ -492,7 +492,7 @@ popen_read_timeout(struct popen_handle *handle, void *buf,
  * Possible errors:
  *
  * - IllegalParams: a parameter check fails:
- *   - flags: neither stdin, stdout nor stderr is choosen.
+ *   - flags: neither stdin, stdout nor stderr is set.
  *   - handle: handle does not support the requested IO operation
  *             (one of fds is not piped).
  */
@@ -509,7 +509,7 @@ popen_shutdown(struct popen_handle *handle, unsigned int flags)
 	/* At least one ..._FD_STDx flag should be set. */
 	if (flags == 0) {
 		diag_set(IllegalParams,
-			 "popen: neither stdin, stdout nor stderr is choosen");
+			 "popen: neither stdin, stdout nor stderr is set");
 		return -1;
 	}