From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com
 [209.85.167.67])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 169834696C3
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 15 Apr 2020 19:21:08 +0300 (MSK)
Received: by mail-lf1-f67.google.com with SMTP id u10so3090588lfo.8
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 15 Apr 2020 09:21:07 -0700 (PDT)
Date: Wed, 15 Apr 2020 19:21:05 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200415162105.GO3072@uranus>
References: <20200415141359.16253-1-gorcunov@gmail.com>
 <20200415160902.GA21441@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200415160902.GA21441@atlas>
Subject: Re: [Tarantool-patches] [PATCH] vclock: rename vclock_reset to
	vclock_set
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>, Serge Petrenko <sergepetrenko@tarantool.org>

On Wed, Apr 15, 2020 at 07:09:02PM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov@gmail.com> [20/04/15 17:16]:
> > The `reset` keyword is too overloaded, its traditional
> > context is to setup some value either to zero or to default.
> > 
> > That is not what we're doing in this helper: we rather set up
> > a new value to the replica_id in the map, keeping consistency
> > of the sum.
> 
> > Thus lets name it as it should -- vclock_set.
> 
> Well, one could argue that it's impossible to set a vclock
> component without violating consistency - vclock should never go
> back. 
> 
> reset() indicates that it can unwind the clock.

Didn't you just named it in correct way -- vlock_unwind() ;-)
Anyway, we've been talking about this name in tchat and
I gave up. Drop the patch please.