From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2997C4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 15 Apr 2020 11:25:32 +0300 (MSK)
Date: Wed, 15 Apr 2020 11:25:30 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200415082530.GA40826@pony.bronevichok.ru>
References: <eb9cc600f14a22aa1fb622d813d1b272d385f12d.1586929647.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <eb9cc600f14a22aa1fb622d813d1b272d385f12d.1586929647.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: remove Ubuntu 19.04
	Disco
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi,

see comments inline

On 09:07 Wed 15 Apr , Alexander V. Tikhonov wrote:
> Removed Ubuntu 19.04 Disco from testing which is EOL.
> 
> Close #4896
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4896-ubuntu1904-eol-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4896
> 
>  .gitlab-ci.yml | 14 ++++----------
>  .travis.yml    |  3 ---
>  2 files changed, 4 insertions(+), 13 deletions(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index cd710027f..9c996fd7b 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -323,12 +323,6 @@ ubuntu_18_04:
>      OS: 'ubuntu'
>      DIST: 'bionic'
>  
> -ubuntu_19_04:
> -  <<: *pack_definition
> -  variables:
> -    OS: 'ubuntu'
> -    DIST: 'disco'
> -
>  ubuntu_19_10:
>    <<: *pack_definition
>    variables:
> @@ -415,17 +409,17 @@ ubuntu_18_04_deploy:
>      OS: 'ubuntu'
>      DIST: 'bionic'
>  
> -ubuntu_19_04_deploy:
> +ubuntu_19_10_deploy:
>    <<: *deploy_definition
>    variables:
>      OS: 'ubuntu'
> -    DIST: 'disco'
> +    DIST: 'eoan'

I don't know our policy regarding OS support, but do we want to support
non-LTS releases? 19.10 is non-LTS.

> -ubuntu_19_10_deploy:
> +ubuntu_20_04_deploy:
>    <<: *deploy_definition
>    variables:
>      OS: 'ubuntu'
> -    DIST: 'eoan'
> +    DIST: 'focal'
>  
>  debian_8_deploy:
>    <<: *deploy_definition
> diff --git a/.travis.yml b/.travis.yml
> index c63ab3ebd..41540fb79 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -67,9 +67,6 @@ jobs:
>        - name: "Ubuntu Bionic (18.04) build + deploy DEB"
>          env: OS=ubuntu DIST=bionic
>          if: branch = "master"
> -      - name: "Ubuntu Disco (19.04) build + deploy DEB"
> -        env: OS=ubuntu DIST=disco
> -        if: branch = "master"
>        - name: "Ubuntu Eoan (19.10) build + deploy DEB"
>          env: OS=ubuntu DIST=eoan
>          if: branch = "master"
> -- 
> 2.17.1
> 

-- 
sergeyb@