From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com
 [209.85.167.65])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id DDFB04696C3
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 15 Apr 2020 10:39:32 +0300 (MSK)
Received: by mail-lf1-f65.google.com with SMTP id 131so1812633lfh.11
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 15 Apr 2020 00:39:32 -0700 (PDT)
Date: Wed, 15 Apr 2020 10:39:30 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200415073930.GK3072@uranus>
References: <cover.1586862436.git.alexander.turenko@tarantool.org>
 <c953d23768e51fa14f76e82af85ee04111bfb620.1586862436.git.alexander.turenko@tarantool.org>
 <20200415042136.p6udliisud4da2kf@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200415042136.p6udliisud4da2kf@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH 11/12] popen: clarify
	popen_read_timeout error message
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Wed, Apr 15, 2020 at 07:21:36AM +0300, Alexander Turenko wrote:
> >  
> >  	if (!(flags & (POPEN_FLAG_FD_STDOUT | POPEN_FLAG_FD_STDERR))) {
> > -		diag_set(IllegalParams, "popen: POPEN_FLAG_FD_STD{OUT,ERR} are "
> > -			 "unset both");
> > +		diag_set(IllegalParams,
> > +			 "popen: neither stdout nor stderr is choosen");
> >  		return -1;
> >  	}
> 
> I was inattentive: there is an error message of the same style in
> popen_read_timeout(). Those functions should be changed both together.

I think better "popen: neither stdout nor stderr is set", but no
strong preferences here (except there is no such word as 'choosen')