From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 4ACC34696C3
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 14 Apr 2020 11:28:20 +0300 (MSK)
Date: Tue, 14 Apr 2020 11:28:18 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200414082818.GE51517@pony.bronevichok.ru>
References: <cover.1586263386.git.avtikhon@tarantool.org>
 <b09f44b856e91f1006bd5b3e226a7be0b65b7859.1586263386.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b09f44b856e91f1006bd5b3e226a7be0b65b7859.1586263386.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1 2/2] gitlab-ci: set static docker
	build release testing
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>, tarantool-patches@dev.tarantool.org

Thanks for the patch!

LGTM

On 17:03 Tue 07 Apr , Alexander V. Tikhonov wrote:
> Returned the static build based on Dockerfile to gitlab-ci release branches
> testing after the issues with missed openssl version fixed at PR #4831.
> 
> Follow up #4831
> ---
>  .gitlab-ci.yml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index cd710027f..f0d5d9b7c 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -454,6 +454,8 @@ static_build:
>  
>  static_docker_build:
>    <<: *release_only_definition
> -  <<: *pack_test_definition
> +  stage: test
> +  tags:
> +    - deploy_test
>    script:
>      - ${GITLAB_MAKE} test_static_docker_build
> -- 
> 2.17.1
> 

-- 
sergeyb@