From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C53D34696C3
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 14 Apr 2020 11:28:04 +0300 (MSK)
Date: Tue, 14 Apr 2020 11:28:02 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200414082802.GD51517@pony.bronevichok.ru>
References: <cover.1586263386.git.avtikhon@tarantool.org>
 <1207821e4fc18312a9916d81a55a8eacd75a67b3.1586263386.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1207821e4fc18312a9916d81a55a8eacd75a67b3.1586263386.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1 1/2] build: disable cache for
	static build Dockerfile
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>, tarantool-patches@dev.tarantool.org

Thanks for the patch!

LGTM

On 17:03 Tue 07 Apr , Alexander V. Tikhonov wrote:
> Found that static build based on Dockerfile used external link
> and missed that it was removed, like it was in #4830. To avoid
> of the same issues the cache for building the Dockerfile was
> disabled with '--no-cache' option at docker build command.
> 
> Follow up #4830
> ---
>  .travis.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.travis.mk b/.travis.mk
> index f709a18b6..54a4d5d91 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -143,7 +143,7 @@ test_static_build: deps_debian_static
>  	CMAKE_EXTRA_PARAMS=-DBUILD_STATIC=ON make -f .travis.mk test_debian_no_deps
>  
>  test_static_docker_build:
> -	docker build --network=host --build-arg RUN_TESTS=ON -f Dockerfile.staticbuild .
> +	docker build --no-cache --network=host --build-arg RUN_TESTS=ON -f Dockerfile.staticbuild .
>  
>  #######
>  # OSX #
> -- 
> 2.17.1
> 

-- 
sergeyb@