From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E66694696C3 for ; Tue, 14 Apr 2020 11:07:50 +0300 (MSK) Date: Tue, 14 Apr 2020 11:07:48 +0300 From: Sergey Bronnikov Message-ID: <20200414080748.GB51517@pony.bronevichok.ru> References: <96ee72a968b3299e4b086ffc71d8cefb8d76b7f0.1586789350.git.avtikhon@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <96ee72a968b3299e4b086ffc71d8cefb8d76b7f0.1586789350.git.avtikhon@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2 1/1] gitlab-ci: disable at OSX curl SSL cert check List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: Oleg Piskunov , tarantool-patches@dev.tarantool.org Hi, Thanks for the patch. See 2 comments inline. On 17:53 Mon 13 Apr , Alexander V. Tikhonov wrote: > Formula tntpython2.rb consist of the packages which download target host > does not have valid SSL certificate, disabled curl SSL check for it. 1. From patch it is unclear what host has an invalid SSL certificate. Could you elaborate? > Close #4883 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/osx_15_catalina-full-ci > Issue: https://github.com/tarantool/tarantool/issues/4883 > > .travis.mk | 23 +++++++++++++++++------ > 1 file changed, 17 insertions(+), 6 deletions(-) > > diff --git a/.travis.mk b/.travis.mk > index 001752844..68cc12c0b 100644 > --- a/.travis.mk > +++ b/.travis.mk > @@ -154,22 +154,33 @@ test_static_docker_build: > # OSX # > ####### > > -# since Python 2 is EOL it's latest commit from tapped local formula is used > OSX_PKGS=openssl readline curl icu4c libiconv zlib autoconf automake libtool \ > - cmake file://$${PWD}/tools/brew_taps/tntpython2.rb > + cmake > > deps_osx: > - # install brew using command from Homebrew repository instructions: > + # Install brew using command from Homebrew repository instructions: > # https://github.com/Homebrew/install > # NOTE: 'echo' command below is required since brew installation > # script obliges the one to enter a newline for confirming the > # installation via Ruby script. > brew update || echo | /usr/bin/ruby -e \ > "$$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)" > - # try to install the packages either upgrade it to avoid of fails > - # if the package already exists with the previous version > + # Try to install the packages either upgrade it to avoid of fails > + # if the package already exists with the previous version. > brew install --force ${OSX_PKGS} || brew upgrade ${OSX_PKGS} > - pip install --force-reinstall -r test-run/requirements.txt > + # Since Python 2 is EOL, it's latest commit from tapped local formula is > + # used. Some packages from tntpython2.rb formula use external download > + # hosts which do not have valid SSL certificate. To resolve it the SSL > + # certificates check need to be disabled during formula installation. > + echo insecure >>$${HOME}/.curlrc > + brew install --force file://$${PWD}/tools/brew_taps/tntpython2.rb || : > + sed '$$d' $${HOME}/.curlrc >$${HOME}/.curlrc.new && \ > + mv $${HOME}/.curlrc.new $${HOME}/.curlrc 2. Failed to understand this magick with .curlrc. Could you explain? > + python2 -V > + pip install --trusted-host files.pythonhosted.org \ > + --upgrade pip setuptools > + pip install --trusted-host files.pythonhosted.org \ > + --force-reinstall -r test-run/requirements.txt > > build_osx: > cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON ${CMAKE_EXTRA_PARAMS} > -- > 2.17.1 > -- sergeyb@