From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BE0894696C3
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 14 Apr 2020 01:35:13 +0300 (MSK)
Date: Mon, 13 Apr 2020 22:35:12 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200413223512.GD24818@tarantool.org>
References: <cover.1586708735.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1586708735.git.imeevma@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] sql: fix order of inserted
	rows
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

On 12 Apr 19:29, imeevma@tarantool.org wrote:
> This patch-set fixes order of inserted rows in case ephemeral
> space is used. The order now is the same in which these values
> were inserted originally. Wrong order could lead to an error in
> case AUTOINCREMENT feature was used.

This is second version of patch, so it would be nice to see
changelog describing differences between versions.

> https://github.com/tarantool/tarantool/issues/4256
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4256-fix-order-during-insertion
> 
> #ChangeLog
>  - The inserted values will now always be inserted in the order in
>    which they were given (gh-4256).
> 
> Mergen Imeev (2):
>   sql: specify field types in ephemeral space format
>   sql: do not change order of inserted values
> 
>  src/box/space_def.c                                |  5 +-
>  src/box/space_def.h                                |  3 +-
>  src/box/sql.c                                      | 68 ++++++++++++++++------
>  src/box/sql/insert.c                               | 19 +++++-
>  src/box/sql/select.c                               |  2 +
>  src/box/sql/sqlInt.h                               |  2 +
>  src/box/sql/vdbe.c                                 | 19 +-----
>  src/box/tuple_format.c                             | 22 ++++---
>  ...256-do-not-change-order-during-insertion.result | 50 ++++++++++++++++
>  ...6-do-not-change-order-during-insertion.test.lua | 15 +++++
>  10 files changed, 153 insertions(+), 52 deletions(-)
>  create mode 100644 test/sql/gh-4256-do-not-change-order-during-insertion.result
>  create mode 100644 test/sql/gh-4256-do-not-change-order-during-insertion.test.lua
> 
> -- 
> 2.7.4
>