From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergos@tarantool.org>
Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 183FA4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 13 Apr 2020 22:49:33 +0300 (MSK)
Date: Mon, 13 Apr 2020 22:49:31 +0300
From: Sergey Ostanevich <sergos@tarantool.org>
Message-ID: <20200413194931.GB1734@tarantool.org>
References: <cover.1586650013.git.v.shpilevoy@tarantool.org>
 <20200412113423.GA28681@atlas>
 <84069240-b5a4-9e61-09f4-a347fe53d54c@tarantool.org>
 <20200413094004.GB16266@atlas> <20200413094230.GC16266@atlas>
 <533bd68c-4bbb-446a-6265-da4f47d451f1@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <533bd68c-4bbb-446a-6265-da4f47d451f1@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 00/43] Unhide symbols
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi, Vlad! 

Thanks for the patch, still I've got a question:

> >> It also adds explicit -Wl,exported_symbols_list
> > 
> > Basically the right fix is to remove this link option, not come up
> > with 43 patches.
> 
> It is not enough. Static library symbols are not exported, if they
> are not used. Linker drops them. It means almost all needed symbols
> are removed when you just remove the option.

If those symbols are removed, does it mean they're not used in the
product? Why one (even Mons!) will need to call a function, that is not
a part of the product then?

Regards,
Sergos