From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2D6644696C3 for ; Mon, 13 Apr 2020 16:40:24 +0300 (MSK) Date: Mon, 13 Apr 2020 16:40:20 +0300 From: Kirill Yukhin Message-ID: <20200413134020.h3e5cmlhc6suo5sc@tarantool.org> References: <20200403140017.GE2993@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200403140017.GE2993@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 2/4] box: add binary search for _session_settings space List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Hello, On 03 Apr 14:00, Nikita Pettik wrote: > On 30 Mar 12:13, Chris Sosnin wrote: > > As it is mentioned in implementation, it is important > > that _session_settings options are sorted by name, so > > there is no need in linear lookup and we can replace it > > with binary search. > > > > Closes #4712 > > --- > > Still I see no need for this patch. It is unclear which improvements > it introduces except for code complication. I agree, let's drop it. -- Regards, Kirill Yukhin