From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C222F4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 13 Apr 2020 16:06:46 +0300 (MSK)
Date: Mon, 13 Apr 2020 16:06:12 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200413130612.GA27992@pony.bronevichok.ru>
References: <c6e3f4cb6c9425cd37ac91f5a4f5a62d605305b9.1586525094.git.sergeyb@tarantool.org>
 <D5D94536-3340-4359-8B77-2930A912A4A4@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <D5D94536-3340-4359-8B77-2930A912A4A4@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] Fix flaky test engine/ddl
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: o.piskunov@tarantool.org, tml <tarantool-patches@dev.tarantool.org>

Hi!

Sergey, thanks for review.

On 15:55 Sat 11 Apr , Serge Petrenko wrote:
> Hi! Thanks for the patch!
>
> I think the check can’t fail after `box.snapshot()` even without wait_cond().
> You’ve already waited for the index to build right before `box.snapshot()`.
> It’ s better to leave the last 2 checks without wait_cond to emphasize that
> nothing could happen during `box.snapshot()`.

You are wrong. Test is failed when wait_cond() below 'box.snapshot()' removed.

S.