From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3E7934696C3
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 13 Apr 2020 13:00:24 +0300 (MSK)
Received: by mail-lj1-f196.google.com with SMTP id r7so8106358ljg.13
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 13 Apr 2020 03:00:24 -0700 (PDT)
Date: Mon, 13 Apr 2020 13:00:21 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200413100021.GW3072@uranus>
References: <cover.1586606685.git.sergepetrenko@tarantool.org>
 <b6b0188089089533458d2f4bfd6d13487c466c36.1586606685.git.sergepetrenko@tarantool.org>
 <20200411163358.GU3072@uranus>
 <7EA6DA75-7106-4E6B-9AC7-59B82B718717@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7EA6DA75-7106-4E6B-9AC7-59B82B718717@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/2] trigger: add trigger_is_set()
	method
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Mon, Apr 13, 2020 at 12:53:45PM +0300, Serge Petrenko wrote:
> > 
> > so that trigger_clear won't fail without if statement?
> 
> This is doing the same as trigger_create(&&on_close_log);

Yes, except it eliminates redundant trigger_create call :)

> Let’s just omit the if statement then together with the patch
> adding trigger_is_set()?

Yeah, sounds good, lets do it.