From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id F2D5D4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 11 Apr 2020 21:18:34 +0300 (MSK)
Date: Sat, 11 Apr 2020 21:11:28 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200411181128.GI5713@tarantool.org>
References: <e2bc28149fb628dded1a9b1bd42180fa59b64e82.1586301544.git.v.shpilevoy@tarantool.org>
 <20200408153339.GF5713@tarantool.org>
 <9c602d2d-9963-b8f3-46a9-eacaf1a94278@tarantool.org>
 <20200411093858.GH5713@tarantool.org>
 <66c72a67-ccbc-c2b3-ce84-df27a32d69ab@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <66c72a67-ccbc-c2b3-ce84-df27a32d69ab@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 1/1] box: export box_session_push
	to the public C API
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Vlad,

On 11.04.20, Vladislav Shpilevoy wrote:
> Hi! Thanks for the review!
> 

<snipped>

> 
> > The result value is not checked, but <port_msgpack_set_plain> returns -1
> > when OOM occurs.
> 
> No need to check result. port_mspack_set_plain() not only returns -1, it
> also keeps port->plain NULL. If it is NULL, it is an error.
> 
> port_mspack_dump_plain() returns port->plain. Therefore if there was an
> error, it will return NULL with a correctly installed diag.

OK, thanks, got it. It might be useful to drop a couple words regarding
it. Feel free to ignore.

-- 
Best regards,
IM