From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4F3BF4696C3 for ; Sat, 11 Apr 2020 10:30:29 +0300 (MSK) Received: by mail-lf1-f67.google.com with SMTP id h6so2840361lfc.0 for ; Sat, 11 Apr 2020 00:30:29 -0700 (PDT) Date: Sat, 11 Apr 2020 10:30:26 +0300 From: Cyrill Gorcunov Message-ID: <20200411073026.GT3072@uranus> References: <5f71273b0240cfc9cb1ee6f6473e30850650be25.1586557519.git.alexander.turenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f71273b0240cfc9cb1ee6f6473e30850650be25.1586557519.git.alexander.turenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] popen: fix 'may be clobbered' compiler warning List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Turenko Cc: tarantool-patches@dev.tarantool.org On Sat, Apr 11, 2020 at 01:28:07AM +0300, Alexander Turenko wrote: > I guess a compiler assumes that the code inside vfork may use the stack > slot that corresponds the variable and so clobber it. The recent commit > 07a07b3cc7b85375d20b3fc6ca1e5060304f337b ('popen: decouple logger fd > from stderr') adds read from this variable after vfork() in the parent > process. > > The warning is produced on RelWithDebInfo build with LTO enabled on GCC > 9.2.0 (locally) and on GCC 8.3.0 (in CI). > > Part of #4031 Acked-by: Cyrill Gorcunov