From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1FEAC4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 10 Apr 2020 17:34:51 +0300 (MSK)
Date: Fri, 10 Apr 2020 17:34:49 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200410143449.GB36000@pony.bronevichok.ru>
References: <cover.1586421151.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1586421151.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1 0/2] gitlab-ci: add Catalina OSX
	10.15
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi,

Sasha, thanks for the patch. See my comment below.

On 11:40 Thu 09 Apr , Alexander V. Tikhonov wrote:
> gitlab-ci: add Catalina OSX 10.15
>     
> Added Catalina OSX 10.15 to gitlab-ci testing and removed OSX 10.13,
> due to decided to have only 2 last major releases, for now it is
> 10.14 and 10.15 OSX versions. Also changed the commit job for branches
> from 10.14 to 10.15 OSX version.
>     
> Added to OSX 10.15 additional call to /etc/profile to setup the PATH,
> otherwise it doesn't have the path to brew installed packages.

PATH can be adjusted in runtime with 'export' call and by using
user-specific $HOME/.profile and reloading it to current environemnt.
What are the reasons to touch system-wide file?

> Formula tntpython2.rb consist of the packages which download target host
> does not have valid SSL certificate, disabled curl SSL check for it,
> also the same issue resolved for pip packages.
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/osx_15_catalina-full-ci
> 
> Alexander V. Tikhonov (2):
>   build: disable at OSX curl SSL
>   gitlab-ci: add Catalina OSX 10.15
> 
>  .gitlab-ci.yml | 11 ++++++-----
>  .travis.mk     | 15 +++++++++++++--
>  2 files changed, 19 insertions(+), 7 deletions(-)
> 
> -- 
> 2.17.1
> 

-- 
sergeyb@