From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id DE0904696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 10 Apr 2020 15:57:58 +0300 (MSK)
Date: Fri, 10 Apr 2020 12:57:57 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200410125757.GB9428@tarantool.org>
References: <cover.1585308644.git.imeevma@gmail.com>
 <bed63c7b293d04ba706f102ec4e3af2411f0ec70.1585308644.git.imeevma@gmail.com>
 <20200327165417.GD9287@tarantool.org>
 <20200410104122.GB20019@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200410104122.GB20019@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 2/3] sql: fix implicit cast from
	STRING to INTEGER
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 10 Apr 13:41, Mergen Imeev wrote:
> On Fri, Mar 27, 2020 at 04:54:17PM +0000, Nikita Pettik wrote:
> > On 27 Mar 14:33, imeevma@tarantool.org wrote:
> > > Prior to this patch, STRING, which contains the DOUBLE value,
> > > could be implicitly cast to INTEGER. This was done by converting
> > > STRING to DOUBLE and then converting this DOUBLE value to INTEGER.
> > > This may affect the accuracy of CAST(), so it was forbidden.
> > > 
> > > Example:
> > > box.execute("CREATE TABLE t(i INT PRIMARY KEY);")
> > > 
> > > Before patch:
> > > box.execute("INSERT INTO t VALUES ('111.1');")
> > > box.execute("SELECT * FROM t;")
> > > Result: 111
> > > 
> > > After patch:
> > > box.execute("INSERT INTO t VALUES ('1.1');")
> > > Result: 'Type mismatch: can not convert 1.1 to integer'
> > > 
> > > box.execute("INSERT INTO t VALUES ('1.0');")
> > > Result: 'Type mismatch: can not convert 1.0 to integer'
> > > 
> > > box.execute("INSERT INTO t VALUES ('1.');")
> > > Result: 'Type mismatch: can not convert 1. to integer'
> > 
> > Is comparison predicat affected?
> > 
> No, since all implicit casts in case of comparison executed
> inside of comparisons opcodes.

You should have mentioned this fact in commit message.

LGTM otherwise.