From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 78A874696C3 for ; Fri, 10 Apr 2020 15:46:43 +0300 (MSK) Date: Fri, 10 Apr 2020 12:46:42 +0000 From: Nikita Pettik Message-ID: <20200410124642.GA9428@tarantool.org> References: <01024a2279b5c030f272d2a97ce8bd83f8ababc3.1585308644.git.imeevma@gmail.com> <20200327164604.GC9287@tarantool.org> <20200410103945.GA20019@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200410103945.GA20019@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v4 1/3] sql: fix CAST() from STRING to INTEGER List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mergen Imeev Cc: tarantool-patches@dev.tarantool.org On 10 Apr 13:39, Mergen Imeev wrote: > Hi! Thank you for review. My answers and new patch below. > > On Fri, Mar 27, 2020 at 04:46:04PM +0000, Nikita Pettik wrote: > > On 27 Mar 14:33, imeevma@tarantool.org wrote: > > > > Could you please find Peter's table containing current/expected cast > > behaviours and verify that this patch doesn't contradict it? What about this? > > > diff --git a/src/box/sql/vdbemem.c b/src/box/sql/vdbemem.c > > > index aad030d..de1d9c3 100644 > > > --- a/src/box/sql/vdbemem.c > > > +++ b/src/box/sql/vdbemem.c > > > @@ -696,7 +696,7 @@ sqlVdbeMemCast(Mem * pMem, enum field_type type)