From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1C0CF4696C3 for ; Fri, 10 Apr 2020 15:21:07 +0300 (MSK) Date: Fri, 10 Apr 2020 15:21:05 +0300 From: Alexander Turenko Message-ID: <20200410122105.dddmo34botaoo2gi@tkn_work_nb> References: <20200410115000.GS3072@uranus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200410115000.GS3072@uranus> Subject: Re: [Tarantool-patches] [PATCH 13/13] popen: use of exception safe functions for IO List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov Cc: tarantool-patches@dev.tarantool.org On Fri, Apr 10, 2020 at 02:50:00PM +0300, Cyrill Gorcunov wrote: > On Fri, Apr 10, 2020 at 05:50:51AM +0300, Alexander Turenko wrote: > > popen read / write functions provides are written in C and intended to Fixed typo: removed 'provides'. > > be used from C: the contract is to return -1 at failure and set an entry > > to the diagnostics area. However a C++ exception from coio read / write > > functions would pass over a popen function stack frame. > > > > The solution is to use the recently introduced coio exception safe > > functions. > > > > Part of #4031 > Acked-by: Cyrill Gorcunov Thanks for the review!