From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D26514696C3 for ; Fri, 10 Apr 2020 11:33:51 +0300 (MSK) Received: by mail-lj1-f196.google.com with SMTP id q22so1264567ljg.0 for ; Fri, 10 Apr 2020 01:33:51 -0700 (PDT) Date: Fri, 10 Apr 2020 11:33:49 +0300 From: Cyrill Gorcunov Message-ID: <20200410083349.GQ3072@uranus> References: <04087d1f6a6bab4087b37d831b5fdfb9666b2605.1586486220.git.alexander.turenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <04087d1f6a6bab4087b37d831b5fdfb9666b2605.1586486220.git.alexander.turenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 05/13] say: allow to set a logger file descriptor List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Turenko Cc: tarantool-patches@dev.tarantool.org On Fri, Apr 10, 2020 at 05:50:43AM +0300, Alexander Turenko wrote: ... > > /** > - * Default logger file descriptor. > + * Accessors for default logger file descriptor. > + * > + * It is needed for dark magic inside popen implementation. > + * Unlikely it is what you want to use anywhere else. > */ I would rather comment it as "It is needed to keep the logger fd alive if a child process in the popen engine needs own fd intersecting with logger." But up to you. Acked-by: Cyrill Gorcunov