From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A178F4696C3 for ; Fri, 10 Apr 2020 11:29:33 +0300 (MSK) Received: by mail-lf1-f67.google.com with SMTP id w145so852029lff.3 for ; Fri, 10 Apr 2020 01:29:33 -0700 (PDT) Date: Fri, 10 Apr 2020 11:29:31 +0300 From: Cyrill Gorcunov Message-ID: <20200410082931.GP3072@uranus> References: <328813debe7020378d0faa79bc3eee8cd00f6197.1586486220.git.alexander.turenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <328813debe7020378d0faa79bc3eee8cd00f6197.1586486220.git.alexander.turenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 12/13] coio: add *_noxc read / write functions List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Turenko Cc: tarantool-patches@dev.tarantool.org On Fri, Apr 10, 2020 at 05:50:50AM +0300, Alexander Turenko wrote: > The popen implementation is written in C and uses coio read / write > functions. If an exception occurs, it'll pass through the C code. It > should be catched to proceed correctly. > > We usually have foo() and foo_xc() (exception) functions when both > variants are necessary. Here I added non-conventional *_noxc() functions > as the temporary solution to postpone refactoring of the code and all > its usages. > > Part of #4031 Acked-by: Cyrill Gorcunov