From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E630A4696C3 for ; Fri, 10 Apr 2020 11:18:02 +0300 (MSK) Received: by mail-lf1-f66.google.com with SMTP id l11so822148lfc.5 for ; Fri, 10 Apr 2020 01:18:02 -0700 (PDT) Date: Fri, 10 Apr 2020 11:18:00 +0300 From: Cyrill Gorcunov Message-ID: <20200410081800.GM3072@uranus> References: <5e80540e9231da5f073016e53f133cf14ca01a64.1586486220.git.alexander.turenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e80540e9231da5f073016e53f133cf14ca01a64.1586486220.git.alexander.turenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 09/13] popen: remove redundant fd check before perform IO List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Turenko Cc: tarantool-patches@dev.tarantool.org On Fri, Apr 10, 2020 at 05:50:47AM +0300, Alexander Turenko wrote: > The function already checks flags to find out whether the file > descriptor should be available for reading / writing. When it is so, the > corresponding fd is great or equal to zero. > > The further commits will add missed diagnostics for IO functions and it > is hard to write a meaningful error message for a situation that is not > possible. Moreover, we would obligated to document the error as one of > possible failures in a function contract (while it can't occur). > > Part of #4031 Acked-by: Cyrill Gorcunov