From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E7E0D4696C3 for ; Fri, 10 Apr 2020 10:46:44 +0300 (MSK) Received: by mail-lf1-f66.google.com with SMTP id x23so779399lfq.1 for ; Fri, 10 Apr 2020 00:46:44 -0700 (PDT) Date: Fri, 10 Apr 2020 10:46:42 +0300 From: Cyrill Gorcunov Message-ID: <20200410074642.GI3072@uranus> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 04/13] popen: add logging of fds closed in a child List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Turenko Cc: tarantool-patches@dev.tarantool.org On Fri, Apr 10, 2020 at 05:50:42AM +0300, Alexander Turenko wrote: > It is useful for debugging popen behaviour around file descriptors. > > Part of #4031 Acked-by: Cyrill Gorcunov > --- > src/lib/core/popen.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/lib/core/popen.c b/src/lib/core/popen.c > index 3fcbc325a..9d4e6ef3a 100644 > --- a/src/lib/core/popen.c > +++ b/src/lib/core/popen.c > @@ -579,6 +579,8 @@ close_inherited_fds(int *skip_fds, size_t nr_skip_fds) > if (fd_no == -1) > continue; > > + say_debug("popen: close inherited fd [%s:%d]", stdX_str(fd_no), > + fd_no); Can we please shift args a bit, like say_debug("popen: close inherited fd [%s:%d]", stdX_str(fd_no), fd_no);