From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com
 [209.85.167.65])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CB8094696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 10 Apr 2020 10:23:18 +0300 (MSK)
Received: by mail-lf1-f65.google.com with SMTP id h6so741630lfc.0
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 10 Apr 2020 00:23:18 -0700 (PDT)
Date: Fri, 10 Apr 2020 10:23:15 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200410072315.GH3072@uranus>
References: <cover.1586486219.git.alexander.turenko@tarantool.org>
 <f656bfd5cb6938ed226271967e412148a9afc739.1586486220.git.alexander.turenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f656bfd5cb6938ed226271967e412148a9afc739.1586486220.git.alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 03/13] popen: add missed diag_set in
	popen_signal/delete
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Fri, Apr 10, 2020 at 05:50:41AM +0300, Alexander Turenko wrote:
> Lua API will use content of the diagnostics area to report an error to a
> caller, so it is critical to always have proper diagnostics at failure.
> 
> Part of #4031
Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>