From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 90E684696C3
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  9 Apr 2020 13:55:57 +0300 (MSK)
Date: Thu, 9 Apr 2020 10:55:56 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200409105556.GA3864@tarantool.org>
References: <cover.1586381297.git.korablev@tarantool.org>
 <bd03396847c1b5a5657429af2dae35d67af3a3c8.1586381297.git.korablev@tarantool.org>
 <20200409081822.GA21437@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200409081822.GA21437@atlas>
Subject: Re: [Tarantool-patches] [PATCH 1/2] vinyl: init all vars before
 cleanup in vy_lsm_split_range()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

On 09 Apr 11:18, Konstantin Osipov wrote:
> * Nikita Pettik <korablev@tarantool.org> [20/04/09 00:39]:
> 
> > +	struct errinj *inj = errinj(ERRINJ_VY_MAX_TUPLE_SIZE, ERRINJ_INT);
> > +	if (inj != NULL && inj->iparam >= 0) {
> > +		if (inj->iparam-- == 0)
> > +			total_size = vy_max_tuple_size + 1;
> > +	}
> 
> shouldn't this be under #ifdef

Looks like not: most of other errinj() calls are not wrapped in
#ifdef NDEBUG macro (in case of debug build errinj() always
returns NULL).
 
> The patch is LGTM, please solicit another review.
> 
>  
> 
> -- 
> Konstantin Osipov, Moscow, Russia