From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 9266A4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  8 Apr 2020 14:04:13 +0300 (MSK)
Date: Wed, 8 Apr 2020 14:04:09 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200408110409.3saf4wl6tsiqpeo5@tarantool.org>
References: <20200407151500.3410-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200407151500.3410-1-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v12 0/8] replication: prevent nil
 dereference on applier rollback
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

Hello,

On 07 апр 18:14, Cyrill Gorcunov wrote:
> In the series a few fixups including simple code cleanup.
> 
> I've assigned a separate bug for myself for applier redesign
> since I need more time to understand code better
> https://github.com/tarantool/tarantool/issues/4853
> 
> Issue https://github.com/tarantool/tarantool/issues/4730
> Branch gorcunov/gh-4730-diag-raise-master-12
> 
> The series gathers everyone Acks and ready for merging.
> 
> Cyrill Gorcunov (8):
>   box: fix bootstrap comment
>   alter: shrink txn_alter_trigger_new code
>   request: add missing OutOfMemory diag_set
>   applier: add missing diag_set on region_alloc failure
>   replication: merge replica_by_id into replicaset
>   applier: reduce applier_txn_rollback_cb code density
>   applier: prevent nil dereference on applier rollback
>   test: add replication/gh-4730-applier-rollback

I've checked your patchset into 2.2, 2.3 and master.

--
Regards, Kirill Yukhin