From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A59B54696C3
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  8 Apr 2020 00:10:00 +0300 (MSK)
Date: Tue, 7 Apr 2020 21:09:59 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200407210959.GB28079@tarantool.org>
References: <cover.1586183184.git.k.sosnin@tarantool.org>
 <f5e248fcaa209666492586cb9ad9009474e30d69.1586183184.git.k.sosnin@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <f5e248fcaa209666492586cb9ad9009474e30d69.1586183184.git.k.sosnin@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/2] session: store output format in
	struct session
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Chris Sosnin <k.sosnin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 06 Apr 17:33, Chris Sosnin wrote:
> diff --git a/src/box/session.h b/src/box/session.h
> index 6dfc7cba5..9ade6e7a5 100644
> --- a/src/box/session.h
> +++ b/src/box/session.h
> @@ -59,6 +59,12 @@ enum session_type {
>  	session_type_MAX,
>  };
>  
> +enum output_format {
> +	OUTPUT_FORMAT_YAML = 0,
> +	OUTPUT_FORMAT_LUA_LINE,
> +	OUTPUT_FORMAT_LUA_BLOCK,
> +};
> +
>

It would be nice to see explanation concering difference between
LUA_LINE and LUA_BLOCK outputs.

LGTM (looks like pure refactoring).