From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A5FD44696C3
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  8 Apr 2020 00:03:17 +0300 (MSK)
Date: Tue, 7 Apr 2020 21:03:16 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200407210316.GA28079@tarantool.org>
References: <cover.1584110394.git.k.sosnin@tarantool.org>
 <15594780-32ed-abf0-5c39-9b0c7d9438c5@tarantool.org>
 <a49b7127-68dc-06d9-f2d2-1bc10ceb976d@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <a49b7127-68dc-06d9-f2d2-1bc10ceb976d@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] box: fix session.push
 formatting
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 07 Apr 22:29, Vladislav Shpilevoy wrote:
> Hi! I suggest to hurry up, we have the release closer and closer.

Still 54 open issues.
 
> On 04/04/2020 01:42, Vladislav Shpilevoy wrote:
> > Thanks for the fixes!
> > 
> > The patchset LGTM. Except that the changelog is still
> > missing.
> > 
> > Please, add a changelog, and send on a second review.
> > I propose either Nikita or Alexander L.
> > 
> > On 13/03/2020 15:58, Chris Sosnin wrote:
> >> issue: https://github.com/tarantool/tarantool/issues/4686
> >> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4686-session-push-fmt
> >>
> >> Changes in v2:
> >>  - Current format moved to struct session.
> >>  - Applied review fixes.
> >>
> >> Chris Sosnin (2):
> >>   refactoring: store output format in struct session
> >>   box: fix formatting in session.push
> >>
> >>  extra/exports                 |  2 +
> >>  src/box/lua/console.c         | 53 ++++++++++++++++++--------
> >>  src/box/lua/console.lua       | 72 +++++++++++++++++++++++++++--------
> >>  src/box/session.h             | 22 ++++++++---
> >>  test/app-tap/console.test.lua | 14 ++++++-
> >>  5 files changed, 126 insertions(+), 37 deletions(-)
> >>