From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3ABFE4696C4
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  7 Apr 2020 18:15:15 +0300 (MSK)
Date: Tue, 7 Apr 2020 18:15:12 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200407151512.GA5989@pony.bronevichok.ru>
References: <20200403093902.GA42848@pony.bronevichok.ru>
 <20200404093457.GC30022@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200404093457.GC30022@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] Fix luacheck warnings in
 src/lua/*.lua
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imunat@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Igor, thanks for your comments. I have updated patch and moved all supressions
from source code to a luacheck config file.

Sergey

On 12:34 Sat 04 Apr , Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch. It's not a review, I just want to add my two cents
> regarding luacheck usage.
> 
> 1. Please consider the way style violations are organized in uJIT
> repo[1]. You can also group everything into a single file for better
> further maintenance.
> 
> 2. There is also a runner[2] for luacheck, that considers uJIT specifics
> (e.g. ujit table is a global variable similar to Tarantool's box one).
> 
> I guess this approach should be considered, even if you decide to make
> the patch your own way.