From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CDFA04696C3 for ; Tue, 7 Apr 2020 18:15:12 +0300 (MSK) Received: by mail-lj1-f194.google.com with SMTP id z26so23523ljz.11 for ; Tue, 07 Apr 2020 08:15:12 -0700 (PDT) From: Cyrill Gorcunov Date: Tue, 7 Apr 2020 18:14:52 +0300 Message-Id: <20200407151500.3410-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v12 0/8] replication: prevent nil dereference on applier rollback List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirill Yukhin Cc: tml In the series a few fixups including simple code cleanup. I've assigned a separate bug for myself for applier redesign since I need more time to understand code better https://github.com/tarantool/tarantool/issues/4853 Issue https://github.com/tarantool/tarantool/issues/4730 Branch gorcunov/gh-4730-diag-raise-master-12 The series gathers everyone Acks and ready for merging. Cyrill Gorcunov (8): box: fix bootstrap comment alter: shrink txn_alter_trigger_new code request: add missing OutOfMemory diag_set applier: add missing diag_set on region_alloc failure replication: merge replica_by_id into replicaset applier: reduce applier_txn_rollback_cb code density applier: prevent nil dereference on applier rollback test: add replication/gh-4730-applier-rollback src/box/alter.cc | 4 +- src/box/applier.cc | 24 ++- src/box/box.cc | 2 +- src/box/replication.cc | 2 - src/box/replication.h | 2 +- src/box/request.c | 8 +- src/box/txn.c | 13 ++ src/lib/core/errinj.h | 1 + test/box/errinj.result | 1 + .../gh-4730-applier-rollback.result | 145 ++++++++++++++++++ .../gh-4730-applier-rollback.test.lua | 73 +++++++++ test/replication/replica-applier-rollback.lua | 16 ++ test/replication/suite.cfg | 1 + test/replication/suite.ini | 2 +- 14 files changed, 281 insertions(+), 13 deletions(-) create mode 100644 test/replication/gh-4730-applier-rollback.result create mode 100644 test/replication/gh-4730-applier-rollback.test.lua create mode 100644 test/replication/replica-applier-rollback.lua -- 2.20.1