From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com
 [209.85.167.68])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 019B04696C3
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  7 Apr 2020 14:00:35 +0300 (MSK)
Received: by mail-lf1-f68.google.com with SMTP id s13so1998809lfb.9
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 07 Apr 2020 04:00:35 -0700 (PDT)
Date: Tue, 7 Apr 2020 14:00:33 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200407110033.GE3072@uranus>
References: <20200404161524.7466-1-gorcunov@gmail.com>
 <5071F704-034B-4041-BB10-F048F61519CC@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5071F704-034B-4041-BB10-F048F61519CC@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v11 0/8] box/replication: prevent
 nil dereference on applier rollback
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Tue, Apr 07, 2020 at 01:46:08PM +0300, Serge Petrenko wrote:
> 
> Hi! Thanks for the patchset!
> 
> Commits 1,2, 5,6 LGTM except one comment:
> Please use ‘applier’ instead of ‘box/applier’
> prefixes in the commit titles.
> Similarly, ‘replication’ instead of ‘box/replication’ and
> ‘alter’ instead of ‘box/alter’. 

OK, thanks, will do.