From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com
 [209.85.167.68])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 96A1D4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  6 Apr 2020 10:40:31 +0300 (MSK)
Received: by mail-lf1-f68.google.com with SMTP id z23so10971326lfh.8
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 06 Apr 2020 00:40:31 -0700 (PDT)
Date: Mon, 6 Apr 2020 10:40:30 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20200406074030.GC10993@atlas>
References: <20200404161524.7466-1-gorcunov@gmail.com>
 <20200404161524.7466-7-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200404161524.7466-7-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v11 6/8] applier: reduce
 applier_txn_rollback_cb code density
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

* Cyrill Gorcunov <gorcunov@gmail.com> [20/04/05 05:06]:

Trivial, doesn't require a review.

> To make it a bit more readable.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>  src/box/applier.cc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/box/applier.cc b/src/box/applier.cc
> index 2eb1e04fc..2f9c9c797 100644
> --- a/src/box/applier.cc
> +++ b/src/box/applier.cc
> @@ -695,8 +695,10 @@ applier_txn_rollback_cb(struct trigger *trigger, void *event)
>  	/* Setup shared applier diagnostic area. */
>  	diag_set(ClientError, ER_WAL_IO);
>  	diag_move(&fiber()->diag, &replicaset.applier.diag);
> +
>  	/* Broadcast the rollback event across all appliers. */
>  	trigger_run(&replicaset.applier.on_rollback, event);
> +
>  	/* Rollback applier vclock to the committed one. */
>  	vclock_copy(&replicaset.applier.vclock, &replicaset.vclock);
>  	return 0;
> -- 
> 2.20.1
> 

-- 
Konstantin Osipov, Moscow, Russia