From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 72E6E4696C3 for ; Sun, 5 Apr 2020 11:35:31 +0300 (MSK) Received: by mail-lj1-f196.google.com with SMTP id k21so11363526ljh.2 for ; Sun, 05 Apr 2020 01:35:31 -0700 (PDT) Date: Sun, 5 Apr 2020 11:35:22 +0300 From: Konstantin Osipov Message-ID: <20200405083522.GA4900@atlas> References: <20200404161524.7466-1-gorcunov@gmail.com> <20200404161524.7466-2-gorcunov@gmail.com> <20200405073140.GA1561@atlas> <20200405075622.GC3072@uranus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200405075622.GC3072@uranus> Subject: Re: [Tarantool-patches] [PATCH v11 1/8] box: fix bootstrap comment List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov , tarantool-patches@dev.tarantool.org * Cyrill Gorcunov [20/04/05 11:00]: > On Sun, Apr 05, 2020 at 10:31:40AM +0300, Konstantin Osipov wrote: > > * Cyrill Gorcunov [20/04/05 05:06]: > > > We're not starting new master node but > > > a new instance instead. The comment simply > > > leftover from older modifications. > > > > I wrote it and it had a meaning. If we call bootstrap, it's > > definitely a new master here, because we're creating a new > > replicaset uuid. > > Wait, this looks vague. Here what we have inside Sorry, I looked out of the context. My comment is indeed obsolete, perhaps some code rot. The patch is lgtm. -- Konstantin Osipov, Moscow, Russia