From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0178C4696C3 for ; Sat, 4 Apr 2020 19:15:29 +0300 (MSK) Received: by mail-lf1-f67.google.com with SMTP id j17so8305637lfe.7 for ; Sat, 04 Apr 2020 09:15:29 -0700 (PDT) From: Cyrill Gorcunov Date: Sat, 4 Apr 2020 19:15:16 +0300 Message-Id: <20200404161524.7466-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v11 0/8] box/replication: prevent nil dereference on applier rollback List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tml In the series a few fixups including simple code cleanup. I've assigned a separate bug for myself for applier redesign since I need more time to understand code better https://github.com/tarantool/tarantool/issues/4853 Issue https://github.com/tarantool/tarantool/issues/4730 Branch gorcunov/gh-4730-diag-raise-master-11 Cyrill Gorcunov (8): box: fix bootstrap comment box/alter: shrink txn_alter_trigger_new code box/request: add missing OutOfMemory diag_set box/applier: add missing diag_set on region_alloc failure box/replication: merge replica_by_id into replicaset applier: reduce applier_txn_rollback_cb code density box/applier: prevent nil dereference on applier rollback test: add replication/applier-rollback src/box/alter.cc | 4 +- src/box/applier.cc | 24 ++- src/box/box.cc | 2 +- src/box/replication.cc | 2 - src/box/replication.h | 2 +- src/box/request.c | 8 +- src/box/txn.c | 13 ++ src/lib/core/errinj.h | 1 + test/box/errinj.result | 1 + test/replication/applier-rollback-slave.lua | 16 ++ test/replication/applier-rollback.result | 162 ++++++++++++++++++++ test/replication/applier-rollback.test.lua | 81 ++++++++++ test/replication/suite.ini | 2 +- 13 files changed, 305 insertions(+), 13 deletions(-) create mode 100644 test/replication/applier-rollback-slave.lua create mode 100644 test/replication/applier-rollback.result create mode 100644 test/replication/applier-rollback.test.lua -- 2.20.1