From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C79C54696C3 for ; Sat, 4 Apr 2020 12:41:17 +0300 (MSK) Date: Sat, 4 Apr 2020 12:34:57 +0300 From: Igor Munkin Message-ID: <20200404093457.GC30022@tarantool.org> References: <20200403093902.GA42848@pony.bronevichok.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200403093902.GA42848@pony.bronevichok.ru> Subject: Re: [Tarantool-patches] [PATCH] Fix luacheck warnings in src/lua/*.lua List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Bronnikov Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org Sergey, Thanks for the patch. It's not a review, I just want to add my two cents regarding luacheck usage. 1. Please consider the way style violations are organized in uJIT repo[1]. You can also group everything into a single file for better further maintenance. 2. There is also a runner[2] for luacheck, that considers uJIT specifics (e.g. ujit table is a global variable similar to Tarantool's box one). I guess this approach should be considered, even if you decide to make the patch your own way. On 03.04.20, Sergey Bronnikov wrote: > GitHub branch: https://github.com/tarantool/tarantool/tree/ligurio/gh-4681-fix-luacheck-warnings > > How-to check: > > $ tarantoolctl rocks install luacheck > $ .rocks/bin/luacheck src/lua/*.lua > > --- > src/lua/argparse.lua | 6 ++-- > src/lua/buffer.lua | 4 +-- > src/lua/clock.lua | 2 +- > src/lua/crypto.lua | 18 +++++----- > src/lua/csv.lua | 5 ++- > src/lua/digest.lua | 6 ++-- > src/lua/env.lua | 2 +- > src/lua/errno.lua | 2 +- > src/lua/fio.lua | 28 ++++++++-------- > src/lua/help.lua | 24 +++++++------- > src/lua/httpc.lua | 3 -- > src/lua/init.lua | 17 +++++----- > src/lua/msgpackffi.lua | 15 ++++----- > src/lua/socket.lua | 66 ++++++++++++++++++------------------- > src/lua/string.lua | 1 - > src/lua/swim.lua | 20 +++++------ > src/lua/tap.lua | 75 ++++++++++++++++++++---------------------- > src/lua/trigger.lua | 3 -- > 18 files changed, 142 insertions(+), 155 deletions(-) > > > -- > sergeyb@ [1]: https://github.com/iponweb/luavela/blob/master/.luacheckrc [2]: https://github.com/iponweb/luavela/blob/master/scripts/run-luacheck -- Best regards, IM