From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4FCFD4696C3 for ; Fri, 3 Apr 2020 16:09:24 +0300 (MSK) Date: Fri, 3 Apr 2020 13:09:23 +0000 From: Nikita Pettik Message-ID: <20200403130923.GC2993@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 0/4] session settings fixes List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Sosnin Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org On 30 Mar 12:13, Chris Sosnin wrote: > issue #1:https://github.com/tarantool/tarantool/issues/4711 > issue #2:https://github.com/tarantool/tarantool/issues/4712 > branch:https://github.com/tarantool/tarantool/tree/ksosnin/gh-4712-session-settings-v2 Nit: while sending next version of patch-set please specify it explicitly with --subject-prefix='PATCH v2' and attach changelog between versions. For example: https://lists.tarantool.org/pipermail/tarantool-patches/2020-March/015103.html > Chris Sosnin (4): > box: replace session_settings modules with a single array > box: add binary search for _session_settings space > box: provide a user friendly frontend for accessing session settings > sql: provide a user friendly frontend for accessing session settings > > extra/mkkeywordhash.c | 1 + > src/box/lua/session.c | 111 +++++++++ > src/box/session.cc | 1 + > src/box/session.h | 2 + > src/box/session_settings.c | 214 +++++++++++------- > src/box/session_settings.h | 53 +++-- > src/box/sql.c | 5 - > src/box/sql/build.c | 104 ++++----- > src/box/sql/parse.y | 5 + > src/box/sql/sqlInt.h | 11 + > src/box/sql/vdbe.c | 50 ++++ > ...rontend.result => session_settings.result} | 147 ++++++++++-- > ...end.test.lua => session_settings.test.lua} | 61 ++++- > 13 files changed, 589 insertions(+), 176 deletions(-) > rename test/box/{gh-4511-access-settings-from-any-frontend.result => session_settings.result} (71%) > rename test/box/{gh-4511-access-settings-from-any-frontend.test.lua => session_settings.test.lua} (64%) > > -- > 2.21.1 (Apple Git-122.3) >