From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C011C4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  2 Apr 2020 17:16:35 +0300 (MSK)
Date: Thu, 2 Apr 2020 14:16:35 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200402141635.GC30923@tarantool.org>
References: <cover.1585097339.git.korablev@tarantool.org>
 <d0a6aaffaaaea96d81a0cd006b9aeb762b2bcea7.1585097339.git.korablev@tarantool.org>
 <8620360c-c99d-f9ea-e7f4-25c97c00c0f1@tarantool.org>
 <20200331174407.GA22927@tarantool.org>
 <0f8cecd0-e483-8ee4-be3b-c848ec9009ae@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <0f8cecd0-e483-8ee4-be3b-c848ec9009ae@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 06/10] box: introduce stacked
 diagnostic area
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 02 Apr 02:29, Vladislav Shpilevoy wrote:
> Thanks for the answers!
> 
> On 31/03/2020 19:44, Nikita Pettik wrote:
> > On 28 Mar 19:59, Vladislav Shpilevoy wrote:
> >> Two more comments.
> >>
> >>> diff --git a/test/box/error.test.lua b/test/box/error.test.lua
> >>> index a0b7d3e78..1fdd6ed98 100644
> >>> --- a/test/box/error.test.lua
> >>> +++ b/test/box/error.test.lua
> >>> @@ -108,4 +108,109 @@ box.error.new(err)
> >>> +
> >>>  space:drop()
> >>
> >> 1. You probably need to keep this 'space:drop()' after
> >> the test related to it.
> > 
> > Isn't it too late?:) I mean test it is related to is finished at
> > line 20, meanwhile space:drop() is already at line 111 (box/error.test.lua
> > is already pushed).
> 
> You still can add 1148 tests after space:drop, not before. In
> that case it at least won't become worse than it is.

Ok, placed space:drop() before #1148 test cases.