From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id E95704696C3
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  2 Apr 2020 13:35:03 +0300 (MSK)
Date: Thu, 2 Apr 2020 13:35:02 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200402103502.tdp3vceeuhuvoyxy@tarantool.org>
References: <cover.1575976611.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cover.1575976611.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 0/5] Improved the static build
 based on Dockerfile
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 10 дек 14:21, Alexander V. Tikhonov wrote:
> Made the following changes at Dockerfile for static build:
>      - changed 'wget' tool use to 'curl -O -L' to avoid of '500' HTTP
>        error respond from download servers
>      - changed the link from sourceforge to github to download
>        the icu4c sources, as suggested on icu4c web site
>      - added 'build' directory removement to avoid of old configuration
>        at build/curl which is used for curl building
>      - removed LD_LIBRARY_PATH environment from curl build, due to the
>        path is empty in real and is not needed
>      - added '-j' option to make tool calls for all builds to speed it up
>        in 4 times
>      - set Dockerfile WORKDIR from the very start of Tarantool sources
>        builds to make the Dockerfile code more readable and removed all
>        duplicating calls to Tarantool sources directory changes.
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/dockerfile-static-build-full-ci
> Issue: -

I've checked your patchset into 1.10, 2.2, 2.3 and master.

--
Regards, Kirill Yukhin