From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 30131441840 for ; Wed, 1 Apr 2020 14:39:27 +0300 (MSK) Date: Wed, 1 Apr 2020 14:33:07 +0300 From: Igor Munkin Message-ID: <20200401113307.GR22874@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v2 0/2] Fix some options of rocks module List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leonid Vasiliev Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Leonid, Thanks for the series! Considering your post-review fixups and omitting other comments I have regarding the tarantoolctl code, it LGTM. Please add a ChangeLog entry for your patchset. Sasha, please proceed with the series. On 16.03.20, Leonid Vasiliev wrote: > https://github.com/tarantool/tarantool/issues/3632 > https://github.com/tarantool/tarantool/issues/4529 > https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4529-fix-show-all > > Some new options (--all and --force) have been added to the white-list for forwarding to the tarantoolctl rocks module. > > Leonid (2): > luarocks: Add a kludge for option all of luarocks search > luarocks: Add a kludge for option force of luarocks remove > > extra/dist/tarantoolctl.in | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > -- > 2.17.1 > -- Best regards, IM