From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2BEAE442BAF
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  1 Apr 2020 12:54:17 +0300 (MSK)
Date: Wed, 1 Apr 2020 12:54:14 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200401095414.GB11949@pony.bronevichok.ru>
References: <cover.1575976611.git.avtikhon@tarantool.org>
 <444449da1110ff892195a9d5c4176f344f3b5260.1575976611.git.avtikhon@tarantool.org>
 <20191218153454.GU1214@tarantool.org>
 <1576747732.702218432@f517.i.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1576747732.702218432@f517.i.mail.ru>
Subject: Re: [Tarantool-patches] [PATCH v2 4/5] static build: added build
 subdirectory cleanup
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Tikhonov <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

LGTM

On 12:28 Thu 19 Dec , Alexander Tikhonov wrote:
> Igor, thanks for the review, I've changed comment as you suggested
> and added the same comment into the Dockerfile.
> 
> 
> >Среда, 18 декабря 2019, 18:37 +03:00 от Igor Munkin <imun@tarantool.org>:
> >
> >Sasha,
> >
> >Thanks for the patch! I left two comments below, please consider them.
> >
> >On 10.12.19, Alexander V. Tikhonov wrote:
> >> Added 'build' directory removement to avoid of old configuration
> >> at build/curl which is used for curl building.
> >
> >The commit message looks a bit complex. I rewrote it a little, as the
> >following:
> >| Added the command for 'build' directory cleanup. It purges all
> >| artefacts produced for curl build, including the old configuration in
> >| build/curl.
> >Feel free to adjust the commit message in your own way.
> >
> >> ---
> >>  Dockerfile.staticbuild | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >> 
> >> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> >> index 66342fa4e..0424179a2 100644
> >> --- a/Dockerfile.staticbuild
> >> +++ b/Dockerfile.staticbuild
> >> @@ -72,7 +72,8 @@ RUN set -x && \
> >> 
> >>  RUN set -x && \
> >>      find . -name 'CMakeFiles' -type d -exec rm -rf {} + && \
> >> -    find . -name 'CMakeCache.txt' -type f -delete
> >> +    find . -name 'CMakeCache.txt' -type f -delete && \
> >
> >Please drop a comment about the build directory source, since it's not
> >created (or even mentioned) within Docker file.
> >
> >> +    rm -rf build
> >> 
> >>  RUN pip install -r /tarantool/test-run/requirements.txt
> >> 
> >> -- 
> >> 2.17.1
> >> 
> >
> >-- 
> >Best regards,
> >IM
> 
> 
> -- 
> Alexander Tikhonov

-- 
sergeyb@