From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BA8224696C3
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  1 Apr 2020 02:27:23 +0300 (MSK)
Date: Wed, 1 Apr 2020 02:21:04 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200331232104.GP22874@tarantool.org>
References: <cover.1584358124.git.lvasiliev@tarantool.org>
 <c5da3dc05b778a45fe7eaca5a75ba72b4ba6c203.1584358124.git.lvasiliev@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <c5da3dc05b778a45fe7eaca5a75ba72b4ba6c203.1584358124.git.lvasiliev@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 1/2] luarocks: Add a kludge for
 option all of luarocks search
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Leonid Vasiliev <lvasiliev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

Leonid,

Thanks for the patch! Please consider the comment below.

On 16.03.20, Leonid Vasiliev wrote:
> From: Leonid <lvasiliev@tarantool.org>
> 
> Fixed the tarantoolctl rocks search flag --all
> 
> Forwarding of the --all flag to tarantoolctl rocks module was added.
> (Command: tarantoolctl rocks search --all)
> 
> Fixes: #4529
> ---
>  extra/dist/tarantoolctl.in | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/extra/dist/tarantoolctl.in b/extra/dist/tarantoolctl.in
> index 6daf866ac..372838edd 100755
> --- a/extra/dist/tarantoolctl.in
> +++ b/extra/dist/tarantoolctl.in

<snipped>

> @@ -945,6 +946,10 @@ local function rocks()
>      end
>      table.insert(positional_arguments, key)
>  
> +    if positional_arguments[1] == "search" and find_arg("all") then

This is a bad check. Consider the following example:
| $ export LUA_PATH="$LUA_PATH;third_party/luarocks/src/?.lua;;"
| $ ./extra/dist/tarantoolctl rocks search --all > valid.out
| $ wc valid.out && echo "Non-empty output"
| 17835  56986 605906 valid.out
| Non-empty output
| $ ./extra/dist/tarantoolctl rocks search all --force > invalid.out
| $ diff -u valid.out invalid.out && echo "Outputs are the same"
| Outputs are the same

You need to check whether 'all' key exists in keyword_arguments, not to
search 'all' substring in arg tables values.

> +        table.insert(positional_arguments, "--all")
> +    end
> +
>      -- Tweak help messages
>      util.see_help = function(command, program)
>          -- TODO: print extended help message here

<snipped>

> -- 
> 2.17.1
> 

-- 
Best regards,
IM