From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AD198441840 for ; Mon, 30 Mar 2020 15:56:43 +0300 (MSK) Received: by mail-lf1-f68.google.com with SMTP id u15so4956233lfi.3 for ; Mon, 30 Mar 2020 05:56:43 -0700 (PDT) Date: Mon, 30 Mar 2020 15:56:42 +0300 From: Konstantin Osipov Message-ID: <20200330125642.GD17886@atlas> References: <878aa23b480e70d95ce0fba5a0572aa58e8c4e6e.1585565637.git.sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878aa23b480e70d95ce0fba5a0572aa58e8c4e6e.1585565637.git.sergepetrenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v5 2/4] replication: hide 0-th vclock components in replication responses List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org * Serge Petrenko [20/03/30 14:08]: > If an anonymous replica is promoted to a normal one and becomes > replication master later, its vclock contains a non-empty zero > component, tracking local changes on this replica from the time when it > had been anonymous. No need to pollute joining instance's vclock with > our non-empty 0 component. > When an anonymous replica reports its status to a remote instance it > should also hide its 0-th vclock component. > > This is needed for backward compatibility with old instances, which > don't ignore 0th vclock component coming from a remote instance by > default. > Also make sure that new instances ignore 0th vclock component. lgtm -- Konstantin Osipov, Moscow, Russia https://scylladb.com