From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 30D2F441840 for ; Mon, 30 Mar 2020 15:52:42 +0300 (MSK) Received: by mail-lj1-f194.google.com with SMTP id i20so17918577ljn.6 for ; Mon, 30 Mar 2020 05:52:42 -0700 (PDT) Date: Mon, 30 Mar 2020 15:52:40 +0300 From: Konstantin Osipov Message-ID: <20200330125240.GA17886@atlas> References: <56c1a9001fafcd7525fdd3c6a68be2760b095532.1585303629.git.sergepetrenko@tarantool.org> <20200328055744.GA23207@atlas> <1A4735AC-A4B1-4CEA-AC0E-0CA173EFDECE@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1A4735AC-A4B1-4CEA-AC0E-0CA173EFDECE@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v4 2/4] replication: hide 0-th vclock components in replication responses List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy * Serge Petrenko [20/03/30 14:03]: > > If you added vclock_compare_ignore0, suggest to introduce and use > > vclock_copy_ignore0 instead of a pair vclock_copy + vclock_reset. > Ok. The diff’s below. The diff is fine. You could make vclock_copy_ingore0 a tad faster I guess. Anyway it's already lgtm. -- Konstantin Osipov, Moscow, Russia https://scylladb.com