From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 808D2441841 for ; Thu, 26 Mar 2020 15:56:27 +0300 (MSK) Date: Thu, 26 Mar 2020 15:56:25 +0300 From: Kirill Yukhin Message-ID: <20200326125625.kql5j6jgtpzt5f2u@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v2 0/3] fio: close unused descriptors automatically List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Hello, On 03 мар 00:29, Vladislav Shpilevoy wrote: > The patchset introduces a fiber worker singleton object and uses > it for garbage collection of fio and SWIM objects. This is a > workaround for inability to yield in ffi.gc hook, which is used by > fio and SWIM. > > SWIM had GC before, but it was creating a new fiber for each GC. > Fio didn't have GC. > > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4727-fio-gc > Issue: https://github.com/tarantool/tarantool/issues/4727 > > @ChangeLog > - fio descriptors are closed on garbage collection (gh-4727). I've checked your patchset into master. -- Regards, Kirill Yukhin