From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 699DA44186D for ; Thu, 26 Mar 2020 15:31:42 +0300 (MSK) Date: Thu, 26 Mar 2020 12:31:41 +0000 From: Nikita Pettik Message-ID: <20200326123141.GC5152@tarantool.org> References: <6375dc2c8988baeab588dcf8fb19615441cb94e1.1585097339.git.korablev@tarantool.org> <03cbfb56-0423-91f8-4394-9bd07a96660e@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <03cbfb56-0423-91f8-4394-9bd07a96660e@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2 02/10] box: rename diag_add_error to diag_set_error List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org On 26 Mar 01:22, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch! > > The commit LGTM. Lets push it right away. Pushed to master. > On 25/03/2020 02:42, Nikita Pettik wrote: > > From: Kirill Shcherbatov > > > > Let's rename diag_add_error() to diag_set_error() because it actually > > replaces an error object in diagnostic area with a new one and this name > > is not representative. Moreover, we are going to introduce a new > > diag_add_error() which will place error at the top of stack diagnostic > > area. > > > > Needed for #1148