From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 28112441841
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 26 Mar 2020 12:04:14 +0300 (MSK)
Received: by mail-lj1-f194.google.com with SMTP id i20so5556331ljn.6
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 26 Mar 2020 02:04:14 -0700 (PDT)
Date: Thu, 26 Mar 2020 12:04:11 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200326090411.GO3197@uranus>
References: <20200324100347.15405-1-gorcunov@gmail.com>
 <20200324100347.15405-3-gorcunov@gmail.com>
 <20200326004737.nu4dcii7zpwesrsp@tkn_work_nb>
 <20200326083122.GN3197@uranus>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200326083122.GN3197@uranus>
Subject: Re: [Tarantool-patches] [PATCH v2 2/2] test: unit/popen -- provide
	a child process
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Thu, Mar 26, 2020 at 11:31:22AM +0300, Cyrill Gorcunov wrote:
...
> +
> +static ssize_t
> +read_safe(int pfd, char *dest, ssize_t bytes)
> +{
> +	ssize_t left = bytes;
> +	ssize_t off = 0;
> +
> +	while (left > 0) {
> +		ssize_t nr = read(pfd, &dest[off], left);
> +		printf("read %zd", nr);

This is redundant printf, I dropped it and force-pushed
into gorcunov/gh-4811-popen-coio-3