From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 6A207446421
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 25 Mar 2020 20:46:05 +0300 (MSK)
Date: Wed, 25 Mar 2020 17:46:04 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200325174604.GB2116@tarantool.org>
References: <cover.1585135623.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1585135623.git.imeevma@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v3 0/2] sql: fix CAST() from BLOB to
	INTEGER
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

On 25 Mar 14:38, imeevma@tarantool.org wrote:
> This patch-set fixes CAST() from BLOB to INTEGER in case a BLOB
> does not have '\0'.
> 
> https://github.com/tarantool/tarantool/issues/4766
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4766-fix-blob-size-for-cast
> 
> 
> Changelog:
>  - CAST() from string contains DOUBLE value to INTEGER or UNSIGNED
>    was disallowed.
>  - Maximum length of a BLOB that is allowed to be cast to INTEGER
>    or UNSIGNED was limited to 12287 bytes.
>  - Fixed wrong behaviour of CAST() in case a BLOB does not have
>    '\0'.

@Changelog entry to release notes is missing.
 
> Mergen Imeev (2):
>   sql: fix CAST() from STRING to INTEGER
>   sql: add '\0' to the BLOB when it is cast to INTEGER
> 
>  src/box/sql/util.c                   | 17 +++++++++----
>  src/box/sql/vdbe.c                   | 11 +++++++--
>  src/box/sql/vdbeInt.h                |  1 -
>  src/box/sql/vdbemem.c                | 45 +++++++++++----------------------
>  test/sql-tap/cast.test.lua           | 48 +++++++++++++++++++++++++++++++++++-
>  test/sql-tap/e_select1.test.lua      |  2 +-
>  test/sql-tap/intpkey.test.lua        |  2 +-
>  test/sql-tap/join.test.lua           |  4 +--
>  test/sql-tap/subquery.test.lua       |  6 ++---
>  test/sql-tap/tkt-9a8b09f8e6.test.lua |  4 +--
>  test/sql/types.result                | 23 +++++++----------
>  11 files changed, 100 insertions(+), 63 deletions(-)
> 
> -- 
> 2.7.4
>