From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E6CD34696C3 for ; Wed, 25 Mar 2020 20:41:32 +0300 (MSK) Date: Wed, 25 Mar 2020 17:41:31 +0000 From: Nikita Pettik Message-ID: <20200325174131.GA2116@tarantool.org> References: <20200325083355.GE18984@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200325083355.GE18984@atlas> Subject: Re: [Tarantool-patches] [PATCH v2 04/10] box/error: introduce box.error.set() method List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Konstantin Osipov , tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org On 25 Mar 11:33, Konstantin Osipov wrote: > * Nikita Pettik [20/03/25 09:32]: > > box.error.set(err) sets err to instance's diagnostics area. Argument err > > is supposed to be instance of error object. This method is required > > since we are going to avoid adding created via box.error.new() errors to > > Tarantool's diagnostic area. > > I agree that it's a good idea to separate creation and addition in > Lua. > > I don't know if it breaks anything, but please search on github > for box.error.new. This is not easy to do, since github doesn't > support '.' in searches, so perhaps you should do: As far as I see, it doesn't break anything: test are passing as expected; it is not in direct contradictions to documentation. > for each (repo in github/tarntool and moonlibs) > git clone repo > cd repo > git grep -r 'box.error.new' . > > Most likely there is some obscure place you break. > > -- > Konstantin Osipov, Moscow, Russia